-
Notifications
You must be signed in to change notification settings - Fork 17.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
board_types.txt: Reserving board IDs for Easy Aerial #27623
Conversation
Tools/AP_Bootloader/board_types.txt
Outdated
@@ -367,6 +367,8 @@ AP_HW_ZeroOne_GNSS 5602 | |||
|
|||
# IDs 6600-6699 reserved for Eagle Eye Drones | |||
|
|||
# IDs 6900-6999 reserved for Easy Aerial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Easy-Aerial need 100 IDs?
If we allocate 100 IDs to every block allocation we can only have 90 allocations in here.
We've been too liberal, really.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, lets do it in blocks of 10
Tools/AP_Bootloader/board_types.txt
Outdated
@@ -367,6 +367,8 @@ AP_HW_ZeroOne_GNSS 5602 | |||
|
|||
# IDs 6600-6699 reserved for Eagle Eye Drones | |||
|
|||
# IDs 6900-6999 reserved for Easy Aerial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, lets do it in blocks of 10
Per DevCall discussion, I've adjusted the allocation to 10 IDs and added a comment and marked this as MergeOnCIPass |
Reserve board IDs for some new Easy Aerial boards.