board_types.txt: Reserving board IDs for Easy Aerial #27623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
reviewed
Jul 24, 2024
Tools/AP_Bootloader/board_types.txt
Outdated
| @@ -367,6 +367,8 @@ AP_HW_ZeroOne_GNSS 5602 | |||
|
|
|||
| # IDs 6600-6699 reserved for Eagle Eye Drones | |||
|
|
|||
| # IDs 6900-6999 reserved for Easy Aerial | |||
There was a problem hiding this comment.
Does Easy-Aerial need 100 IDs?
If we allocate 100 IDs to every block allocation we can only have 90 allocations in here.
We've been too liberal, really.
There was a problem hiding this comment.
ok, lets do it in blocks of 10
tridge
requested changes
Jul 29, 2024
Tools/AP_Bootloader/board_types.txt
Outdated
| @@ -367,6 +367,8 @@ AP_HW_ZeroOne_GNSS 5602 | |||
|
|
|||
| # IDs 6600-6699 reserved for Eagle Eye Drones | |||
|
|
|||
| # IDs 6900-6999 reserved for Easy Aerial | |||
There was a problem hiding this comment.
ok, lets do it in blocks of 10
|
Per DevCall discussion, I've adjusted the allocation to 10 IDs and added a comment and marked this as MergeOnCIPass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reserve board IDs for some new Easy Aerial boards.